Re: [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Feb 24, 2010, 06:22 UTC
- Message-ID
- <cb7bb73a1002232222r354a2ec7l9ea4cfd1c101e8c6@mail.gmail.com>
- In-Reply-To
- <201002240114.11634.markus.heidelberg@web.de>
On Wed, Feb 24, 2010 at 1:14 AM, Markus Heidelberg <markus.heidelberg@web.de> wrote:
Show 5 quoted lines
> > Ah, this doesn't look like what it looked like back then. Commit > 21985a113 (git-gui: handle non-standard worktree locations) changed it, > removing the [file nativename]. I don't know if this was by accident, > but there is another place, where it was changed in a different manner:
My fault, and yes it was by accident.
Show 12 quoted lines
> Compare > > - eval exec $explorer [list [file nativename [file dirname [gitdir]]]] & > + eval exec $explorer $_gitworktree & > > with > > -wm title . "[appname] ([reponame]) [file normalize [file dirname [gitdir]]]" > +wm title . "[appname] ([reponame]) [file normalize $_gitworktree]" > > Maybe _gitworktree should be normalized or nativenamified when it is set > and then will work everywhere it is used for every platform?
The only issue with that would be that GIT_DIR and GIT_WORK_TREE are (re)inizialized from _gitdir and _gitworktree, so it would not be safe if git on Windows works better with unix-style rather than native paths. If git on windows handles native paths fine, it should be no problem.
-- Giuseppe "Oblomov" Bilotta