Re: [msysGit] Re: [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7

From: Pat Thoyts <patthoyts@googlemail.com>
Date: Feb 24, 2010, 12:12 UTC
Message-ID: <a5b261831002240412x30490e25wbec74cdbc1d0ebd2@mail.gmail.com>
In-Reply-To: <cb7bb73a1002232222r354a2ec7l9ea4cfd1c101e8c6@mail.gmail.com>

On 24 February 2010 06:22, Giuseppe Bilotta <giuseppe.bilotta@gmail.com> wrote:

>+               set path [list [string map {/ \\} $path]]

No - Tcl provides [file nativename $path] for this purpose.

Show 6 quoted lines

>
> The only issue with that would be that GIT_DIR and GIT_WORK_TREE are
> (re)inizialized
> from _gitdir and _gitworktree, so it would not be safe if git on
> Windows works better with unix-style rather than native paths. If git
> on windows handles native paths fine, it should be no problem.

Tcl internally uses unix type path separators but once you export this path to the operating system you may need to ensure it is a native path. Typically that means when calling [exec]. [open] is a tcl command and will deal with a path variable in either style. The Tcl exec man page has some notes on the compatibility issues.

Pat.