From: Giuseppe Bilotta Date: Wed, 24 Feb 2010 06:22:33 GMT Subject: Re: [GIT GUI PATCH] git-gui: fix open explorer window on Windows 7 Message-ID: In-Reply-To: <201002240114.11634.markus.heidelberg@web.de> On Wed, Feb 24, 2010 at 1:14 AM, Markus Heidelberg wrote: > > Ah, this doesn't look like what it looked like back then. Commit > 21985a113 (git-gui: handle non-standard worktree locations) changed it, > removing the [file nativename]. I don't know if this was by accident, > but there is another place, where it was changed in a different manner: My fault, and yes it was by accident. > Compare > > -       eval exec $explorer [list [file nativename [file dirname [gitdir]]]] & > +       eval exec $explorer $_gitworktree & > > with > > -wm title . "[appname] ([reponame]) [file normalize [file dirname [gitdir]]]" > +wm title . "[appname] ([reponame]) [file normalize $_gitworktree]" > > Maybe _gitworktree should be normalized or nativenamified when it is set > and then will work everywhere it is used for every platform? The only issue with that would be that GIT_DIR and GIT_WORK_TREE are (re)inizialized from _gitdir and _gitworktree, so it would not be safe if git on Windows works better with unix-style rather than native paths. If git on windows handles native paths fine, it should be no problem. -- Giuseppe "Oblomov" Bilotta