git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: fix "Explore Working Copy" for Windows again

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Feb 25, 2010, 20:44 UTC
Message-ID
<20100225204451.GB12637@book.hvoigt.net>
In-Reply-To
<201002250114.23322.markus.heidelberg@web.de>
On Thu, Feb 25, 2010 at 01:14:22AM +0100, Markus Heidelberg wrote:
Show 11 quoted lines
> It has already been fixed in commit 454efb47 (git-gui (Win): make
> "Explore Working Copy" more robust, 2009-04-01), but has been broken in
> commit 21985a11 (git-gui: handle non-standard worktree locations,
> 2010-01-23) by accidentally replacing too much with a new variable.
> 
> The problem can be reproduced when starting git-gui from within a
> subdirectory. The solution is to convert the path name, explorer.exe is
> invoked with, to a platform native name.
> 
> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> ---

I can confirm that this does fix the issue which is actually also apparent on Windows XP. If no objections occur I would apply this to the devel branch for msysgit.

cheers Heiko
Previous: Markus HeidelbergNext: Pat Thoyts
Message 6 of 13 in “git-gui: fix open explorer window on Windows 7”
  1. git-gui: fix open explorer window on Windows 7Heiko Voigt, Feb 23, 2010
  2. Markus HeidelbergFeb 24, 2010
  3. Giuseppe BilottaFeb 24, 2010
  4. Pat ThoytsFeb 24, 2010
  5. git-gui: fix "Explore Working Copy" for Windows againMarkus Heidelberg, Feb 25, 2010
  6. Heiko VoigtFeb 25, 2010
  7. Pat ThoytsFeb 25, 2010
  8. Johannes SchindelinFeb 26, 2010
  9. Heiko VoigtFeb 27, 2010
  10. Pat ThoytsFeb 24, 2010
  11. Heiko VoigtFeb 25, 2010
  12. Markus HeidelbergFeb 25, 2010
  13. Pat ThoytsFeb 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.