Re: [PATCH] git-gui: fix "Explore Working Copy" for Windows again
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 26, 2010, 00:46 UTC
- Message-ID
- <alpine.DEB.1.00.1002260145510.20986@pacific.mpi-cbg.de>
- In-Reply-To
- <20100225204451.GB12637@book.hvoigt.net>
Hi,
On Thu, 25 Feb 2010, Heiko Voigt wrote:
Show 16 quoted lines
> On Thu, Feb 25, 2010 at 01:14:22AM +0100, Markus Heidelberg wrote: > > It has already been fixed in commit 454efb47 (git-gui (Win): make > > "Explore Working Copy" more robust, 2009-04-01), but has been broken in > > commit 21985a11 (git-gui: handle non-standard worktree locations, > > 2010-01-23) by accidentally replacing too much with a new variable. > > > > The problem can be reproduced when starting git-gui from within a > > subdirectory. The solution is to convert the path name, explorer.exe is > > invoked with, to a platform native name. > > > > Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de> > > --- > > I can confirm that this does fix the issue which is actually also > apparent on Windows XP. If no objections occur I would apply this to the > devel branch for msysgit.
No objections from my side!
Thanks, Dscho