Re: [RFC PATCH v4 11/26] Move WebDAV HTTP push under remote-curl

From: Tay Ray Chuan <rctay89@gmail.com>
Date: Oct 30, 2009, 16:10 UTC
Message-ID: <be6fef0d0910300910me43c77fue6dcb6034dd0ea5b@mail.gmail.com>
In-Reply-To: <1256774448-7625-12-git-send-email-spearce@spearce.org>

Hi,

On Thu, Oct 29, 2009 at 8:00 AM, Shawn O. Pearce <spearce@spearce.org> wrote:

Show 21 quoted lines

> diff --git a/t/t5540-http-push.sh b/t/t5540-http-push.sh
>[snip]
> @@ -57,11 +58,15 @@ test_expect_failure 'push to remote repository with packed refs' '
>         test $HEAD = $(git rev-parse --verify HEAD))
>  '
>
> -test_expect_success ' push to remote repository with unpacked refs' '
> +test_expect_failure 'push already up-to-date' '
> +       git push
> +'
> +
> +test_expect_success 'push to remote repository with unpacked refs' '
>        (cd "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git &&
>         rm packed-refs &&
> -        git update-ref refs/heads/master \
> -               0c973ae9bd51902a28466f3850b543fa66a6aaf4) &&
> +        git update-ref refs/heads/master $ORIG_HEAD &&
> +        git --bare update-server-info) &&
>        git push &&
>        (cd "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git &&
>         test $HEAD = $(git rev-parse --verify HEAD))

Clemens, the following addresses your non-desire to remove the "unpacked refs" test in your earlier email <20091025161630.GB8532@localhost>.

Now that the first push in "push to remote repository with packed refs" succeeds, the "unpacked refs" test is redundant. Since http-push in that first test already updated /refs/heads/master and /info/refs, 'git update-ref' incorrectly reverts the earlier push, and 'git update-server-info' is redundant.

-- 
Cheers,
Ray Chuan