Re: [RFC PATCH v4 26/26] test smart http fetch and push

From: Shawn O. Pearce <spearce@spearce.org>
Date: Oct 29, 2009, 14:37 UTC
Message-ID: <20091029143702.GU10505@spearce.org>
In-Reply-To: <7vpr86dgyj.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > +test_expect_success 'clone http repository' '
> > +	GIT_CURL_VERBOSE=1 git clone $HTTPD_URL/git/repo.git clone 2>err &&
> > +	test_cmp file clone/file &&
> > +	egrep "^([<>]|Pragma|Accept|Content-|Transfer-)" err |
> > +	egrep -v "^< (Server|Expires|Date|Content-Length:|Transfer-Encoding: chunked)" |
> > +	sed -e "
> > +		s/
> > //
> > +		s/^Content-Length: .*$/Content-Length: xxxx/
> > +	" >act &&
> 
> This chomped line is so unlike you---what happened?

I was getting different Content-Lengths on different runs of the
test.  I don't know why.  Here the Content-Length is of the gzip'd
request, it shouldn't be varying with each run, but it seemed to be.

> Also, when the last downstream is sed, why would you even need two egrep
> process?

That's a really good point. This is just stupid, I started with the two egreps to filter the lines, then found I needed to strip CRs, and then had to munge the Content-Length, and I just forgot to merge the egrep cases into the sed script.

I'll fix this.  Thanks.

-- 
Shawn.