Re: [RFC PATCH v4 03/26] pkt-line: Make packet_read_line easier to debug

> > The NUL assignment isn't about safe_read(), its about making the
> > block of 4 bytes read a proper C-style string so we can safely pass
> > it down into the snprintf that is within die().
> 
> I knew and understood all of what you just said.  static linelen[] is not
> about stack allocation.  It's about letting the compiler initialize it to
> five NULs so that you do not have to assign NUL to its fifth place before
> you die.  This removes one added line from your patch.