Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

From: James Denholm <nod.helm@gmail.com>
Date: Apr 27, 2014, 03:01 UTC
Message-ID: <b883baa0-740f-4d2a-b7b1-4cc9294f88ed@email.android.com>
In-Reply-To: <20140427025150.GA26382@sigill.intra.peff.net>

Jeff King <peff@peff.net> wrote:

Show 15 quoted lines

>On Sun, Apr 27, 2014 at 12:35:13PM +1000, James Denholm wrote:
>
>> >Do we even make [subproject and mainline] anymore? It looks like
>they are part
>> >of the tests, but the whole test script runs inside its own trash
>> >directory.
>> 
>> subproject and mainline are actually made in  contrib/subtree,
>> but I'll look at perhaps "fixing" that when I split the proposal
>> into a series as you suggest.
>
>Are they? I couldn't find any reference to them as directories except
>in
>the test script, and doing a "make" from contrib/subtree didn't create
>them.

Yeah, I could be wrong as I don't have the code on-hand at the moment, but from memory they're made and populated by the test script as well. Either way I'll move all that into a subdir of t/ and rejigger the thing, if investigation reveals that as the Done Thing.

>I'll leave it to you to investigate further whether the "clean"
>rules are cruft or not, but certainly if they are, cleaning up cruft is
>a good thing.