Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

From: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
Date: Apr 30, 2014, 03:20 UTC
Message-ID: <20140430032045.GA4613@comcast.net>
In-Reply-To: <6a7bcc79-d9c3-4cf8-8f3b-a6a16298c221@email.android.com>

On Sun, Apr 27, 2014 at 12:35:13PM +1000, James Denholm wrote:

Show 9 quoted lines

> Jeff King <peff@peff.net> wrote:
> >I think the problem is that
> >contrib/subtree does not really have an active dedicated area
> >maintainer.
> 
> Yeah, I can see how that might become a bit of a problem. I was
> actually thinking of doing a bit of work on subtree beyond this
> specific patch, so hopefully that won't be a show-stopper. We'll
> see what happens, I guess.

Agreed. It also doesn't help that when subtree patches are proposed (especially new features instead of obvious bugs), there often seems to be little or no feedback from anyone.

-------- Depending on how much time you have:

This may be outside the scope of work you were planning on, but it might be worth grepping through old mailing list archives for "subtree" patches that haven't been merged, and see if there is anything worth revisiting/resubmitting. I believe most of the following (at least) kind of languished and died, often with little or no real review and feedback:

http://marc.info/?l=git&m=138644067726844&w=2
http://marc.info/?l=git&m=138523794407181&w=2
  - My own series, plus another patch that has roughly the
    same description, but different semantics.

http://marc.info/?l=git&m=136321400525507&w=2
http://marc.info/?l=git&m=136321400525507&w=2
  - Some series from Paul Campbell.

http://marc.info/?l=git&m=136122107605036&w=2
http://marc.info/?l=git&m=135813589922554&w=2
http://marc.info/?l=git&m=136415434127550&w=2
http://marc.info/?l=git&m=136127692217856&w=2
  - Other series.

http://marc.info/?l=git&m=138557714926045&w=2
http://marc.info/?l=git&m=138129106613560&w=2
http://marc.info/?l=git&m=136415882128742&w=2
http://marc.info/?l=git&m=136415654228062&w=2
  - Miscellaneous

And probably others...

(I don't know if these are the latest or "best" versions of these, nor have I really looked at them closely to decide if they are worth including at all. Be sure to exameine not just the discussion around the specific patches, but also the other patches in each series...)

                     - Matthew Ogilvie