Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

From: James Denholm <nod.helm@gmail.com>
Date: Apr 27, 2014, 02:35 UTC
Message-ID: <6a7bcc79-d9c3-4cf8-8f3b-a6a16298c221@email.android.com>
In-Reply-To: <20140426072520.GB7558@sigill.intra.peff.net>

Jeff King <peff@peff.net> wrote:

>I think the problem is that
>contrib/subtree does not really have an active dedicated area
>maintainer.

Yeah, I can see how that might become a bit of a problem. I was actually thinking of doing a bit of work on subtree beyond this specific patch, so hopefully that won't be a show-stopper. We'll see what happens, I guess.

Show 10 quoted lines

>Your changes look fine to me from a cursory examination. It would
>probably be more readable as four patches (the 3 "fix" points from your
>list, plus the "minor fixes" mentioned at the end). Then each patch
>stands on its own, can say what problem it's fixing, and how.
>
> (...)
>
>Do we even make [subproject and mainline] anymore? It looks like they are part
>of the tests, but the whole test script runs inside its own trash
>directory.

subproject and mainline are actually made in contrib/subtree, but I'll look at perhaps "fixing" that when I split the proposal into a series as you suggest.

Thanks for the advice!

Regards, James Denholm.