Re: [PATCH] subtree/Makefile: Standardize (esp. for packagers)

From: nod.helm@gmail.com <nod.helm@gmail.com>
Date: Apr 26, 2014, 04:56 UTC
Message-ID: <3cb4338e-de68-404d-86dc-70cac7e13606@email.android.com>
In-Reply-To: <CAHYYfeGNDLVxzP6zMyJnSi8GxpQaUKGAkqaLfXbZ=8B1k7vvyQ@mail.gmail.com>

On 24 Apr 2014 11:52, <nod.helm@gmail.com> wrote:

Show 16 quoted lines

>
> From: James Denholm <nod.helm@gmail.com>
>
> contrib/subtree/Makefile is a shambles in regards to it's consistency
> with other makefiles, which makes subtree overly painful to include in
> build scripts.
>
> Two major issues are present:
>
> Firstly, calls to git itself (for $(gitdir) and $(gitver)), making
> building difficult on systems that don't have git.
>
> Secondly, the Makefile uses the variable $(libexecdir) for defining the
> exec path.
>
> (...)

I hate to be that guy, but could I get an opinion on the proposed patch? Is git interested in purely makefile patches, or should I find further improvements to make in subtree and purpose this again with those?

Regards, James Denholm.