git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [StGit PATCH v2 1/6] stg mail: Refactor __send_message and friends

From
Karl Wiberg <kha@treskal.com>
Date
Dec 2, 2009, 06:53 UTC
Message-ID
<b8197bcb0912012253l399bb542sab141021e7ff6353@mail.gmail.com>
In-Reply-To
<20091202004605.7737.2077.stgit@bob.kio>
On Wed, Dec 2, 2009 at 1:46 AM, Alex Chiang <achiang@hp.com> wrote:
Show 6 quoted lines
> +    if (smtppassword and not smtpuser):
> +        raise Exception('SMTP password supplied, username needed')
> +    if (smtpusetls and not smtpuser):
> +        raise Exception('SMTP over TLS requested, username needed')
> +    if (smtpuser and not smtppassword):
> +        smtppassword = getpass.getpass("Please enter SMTP password: ")

Sorry if I confused you with my earlier explanation; I only meant that you should use the _form_ "raise Exception('message')", not that you should change the exception type from CmdException to Exception. If you try to trigger these errors, I think you'll find that in the case of CmdException, StGit will print just the message and exit with an error; whereas for straight Exception, it'll print the full backtrace as well under the assumption that it's a program bug.

-- 
Karl Wiberg, kha@treskal.com
   subrabbit.wordpress.com
   www.treskal.com/kalle
Previous: Alex ChiangNext: Alex Chiang
Message 3 of 19 in “add support for git send-email”
  1. 0/6 add support for git send-emailAlex Chiang, Dec 2, 2009
  2. 1/6 stg mail: Refactor __send_message and friendsAlex Chiang, Dec 2, 2009
  3. Karl WibergDec 2, 2009
  4. Alex ChiangDec 3, 2009
  5. 1/6 stg mail: Refactor __send_message and friendsAlex Chiang, Dec 3, 2009
  6. 2/6 stg mail: reorder __build_[message|cover] parametersAlex Chiang, Dec 2, 2009
  7. 3/6 stg mail: make __send_message do moreAlex Chiang, Dec 2, 2009
  8. Karl WibergDec 2, 2009
  9. Alex ChiangDec 3, 2009
  10. Karl WibergDec 4, 2009
  11. 4/6 stg mail: factor out __update_headerAlex Chiang, Dec 2, 2009
  12. 5/6 stg mail: add basic support for git send-emailAlex Chiang, Dec 2, 2009
  13. 6/6 stg mail: don't parse To/Cc/Bcc in --git modeAlex Chiang, Dec 2, 2009
  14. Karl WibergDec 2, 2009
  15. Alex ChiangDec 3, 2009
  16. Karl WibergDec 2, 2009
  17. Catalin MarinasDec 2, 2009
  18. Catalin MarinasDec 6, 2009
  19. Karl WibergDec 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.