[StGit PATCH v2 0/6] add support for git send-email

This is v2 of the series that starts teaching stg mail how to call git send-email.

I made all the changes that Karl recommended, and made sure to run the t1900-mail.sh test at every point in the series (passes successfully).

I also experimented with adding another test case for --git mode, basically duplicating t1900-mail.sh, and then adding the --git argument wherever it made sense.

However, that resulted in failure of the last 3 test cases, which is due to the fact that we no longer parse To/Cc/Bcc command line args in --git mode, and the resulting mbox file was missing the expected recipient addresses.

I played around with that for a while, thinking that I could use git send-email --dry-run to do something equivalent, but then realized that git send-email's run-run mode is definitely not analogous to stg mail's --mbox mode.

The upshot is that in stg mail, --git and --mbox don't interact well, and the resulting mbox file will lack the recipients. This might be fixed in the future if we teach git send-email how to generate mbox files, but then we introduce a versioning problem.

So let's just accept this wart for now, and say, if you want an mbox file generated, don't use --git. That seems reasonable to me.

This mail was sent with the following command line:

	./stg mail --git -a -e --auto -v v2 --prefix=StGit
	--to=catalin.marinas@gmail.com --cc=git

Note that the --cc= contains an alias for the git mailing list that I defined in my ~/.mutt.aliases file (and specified in .gitconfig -> sendemail.aliasesfile and sendemail.aliasfiletype.

Thanks, /ac

---

Alex Chiang (6):
      stg mail: Refactor __send_message and friends
      stg mail: reorder __build_[message|cover] parameters
      stg mail: make __send_message do more
      stg mail: factor out __update_header
      stg mail: add basic support for git send-email
      stg mail: don't parse To/Cc/Bcc in --git mode

 stgit/commands/mail.py |  196 +++++++++++++++++++++++++++---------------------
 1 files changed, 112 insertions(+), 84 deletions(-)