Re: [StGit PATCH v2 0/6] add support for git send-email
- From
Karl Wiberg <kha@treskal.com>
- Date
- Dec 2, 2009, 06:46 UTC
- Message-ID
- <b8197bcb0912012246n3b83866cjb93654effc000242@mail.gmail.com>
- In-Reply-To
- <20091202003503.7737.51579.stgit@bob.kio>
On Wed, Dec 2, 2009 at 1:46 AM, Alex Chiang <achiang@hp.com> wrote:
> I also experimented with adding another test case for --git mode, > basically duplicating t1900-mail.sh, and then adding the --git > argument wherever it made sense.
Ah, good.
Show 14 quoted lines
> However, that resulted in failure of the last 3 test cases, which is > due to the fact that we no longer parse To/Cc/Bcc command line args > in --git mode, and the resulting mbox file was missing the expected > recipient addresses. > > I played around with that for a while, thinking that I could use git > send-email --dry-run to do something equivalent, but then realized > that git send-email's run-run mode is definitely not analogous to > stg mail's --mbox mode. > > The upshot is that in stg mail, --git and --mbox don't interact > well, and the resulting mbox file will lack the recipients. This > might be fixed in the future if we teach git send-email how to > generate mbox files, but then we introduce a versioning problem.
One wild idea: git send-email's --smtp-server flag will accept the (full) path of a sendmail program; writing such a program, just capable enough to receive the outgoing emails and dumping them to a file, should be easy. Another option would be a program that speaks just enough SMTP to accept the mails. (Incidentally, these two would be useful in testing stg mail even without the --git option.)
I fully understand if you'd rather get on with scratching your actual itch, though ...
> So let's just accept this wart for now, and say, if you want an mbox > file generated, don't use --git. That seems reasonable to me.
Sure.
-- Karl Wiberg, kha@treskal.com subrabbit.wordpress.com www.treskal.com/kalle