From: Karl Wiberg Date: Wed, 02 Dec 2009 06:53:26 GMT Subject: Re: [StGit PATCH v2 1/6] stg mail: Refactor __send_message and friends Message-ID: In-Reply-To: <20091202004605.7737.2077.stgit@bob.kio> On Wed, Dec 2, 2009 at 1:46 AM, Alex Chiang wrote: > + if (smtppassword and not smtpuser): > + raise Exception('SMTP password supplied, username needed') > + if (smtpusetls and not smtpuser): > + raise Exception('SMTP over TLS requested, username needed') > + if (smtpuser and not smtppassword): > + smtppassword = getpass.getpass("Please enter SMTP password: ") Sorry if I confused you with my earlier explanation; I only meant that you should use the _form_ "raise Exception('message')", not that you should change the exception type from CmdException to Exception. If you try to trigger these errors, I think you'll find that in the case of CmdException, StGit will print just the message and exit with an error; whereas for straight Exception, it'll print the full backtrace as well under the assumption that it's a program bug. -- Karl Wiberg, kha@treskal.com subrabbit.wordpress.com www.treskal.com/kalle