Re: [PATCH v2 04/10] clar: avoid using the comma operator unnecessarily
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 26, 2025, 07:03 UTC
- Message-ID
- <b6b1fdc7-2ec3-d569-fc58-5f238e98f428@gmx.de>
- In-Reply-To
- <Z-OWmSe3vCDaZLXy@pks.im>
Hi Patrick,
On Wed, 26 Mar 2025, Patrick Steinhardt wrote:
Show 12 quoted lines
> On Tue, Mar 25, 2025 at 11:32:08PM +0000, Johannes Schindelin via GitGitGadget wrote: > > From: Johannes Schindelin <johannes.schindelin@gmx.de> > > > > The comma operator is a somewhat obscure C feature that is often used by > > mistake and can even cause unintentional code flow. In this instance, it > > makes the code harder to read than necessary, too. Better use a > > semicolon instead. > > This code has changed upstream already, but let's roll with your change > anyway. I plan to update the clar to the upstream version soonish once I > have landed integer comparisons, and will take care that there aren't > any other comment operators left.
Thank you for putting so much energy into improving the tests, I really appreciate it!
Ciao, Johannes