Re: [PATCH v2 06/10] diff-delta: explicitly mark intentional use of the comma operator

From: Chris Torek <chris.torek@gmail.com>
Date: Mar 27, 2025, 01:31 UTC
Message-ID: <CAPx1GvfyzdF9HasG3aPQA=Jdb03=3YJvNEDXabGK793CCow=HA@mail.gmail.com>
In-Reply-To: <Z+RkmLzciwT6ubIE@nand.local>

(Just picking the latest message to reply to, not really quite right)

Show 8 quoted lines

> > >             if (moff & 0x000000ff)
> > >                     (void)(out[outpos++] = moff >> 0),  i |= 0x01;
> > >             if (moff & 0x0000ff00)
> > >                     (void)(out[outpos++] = moff >> 8),  i |= 0x02;
> > >             if (moff & 0x00ff0000)
> > >                     (void)(out[outpos++] = moff >> 16), i |= 0x04;
> > >             if (moff & 0xff000000)
> > >                     (void)(out[outpos++] = moff >> 24), i |= 0x08;

Might be overkill but:

        #define XXX(index) do { \
                if (moff & (0xffUL << ((index) * 8))) {
                        out[outpos++] = moff >> ((index) * 8);
                        i |= 1 << (index);
                }
        } while (0)

        XXX(0);
        XXX(1);
        XXX(2);
        XXX(3);

        #undef XXX

would do the trick.  Pick a proper name for XXX of course.

Chris