Re: [PATCH 0/2] Avoid the comma operator

From: Taylor Blau <me@ttaylorr.com>
Date: Mar 26, 2025, 20:17 UTC
Message-ID: <Z+Rg8iz1cV/pSok+@nand.local>
In-Reply-To: <22fe76ff-7940-86bd-af50-c161e3d04864@gmx.de>

On Tue, Mar 25, 2025 at 03:13:47PM +0100, Johannes Schindelin wrote:

Show 8 quoted lines

> > It would be great if there was a compiler warning we could enable for
> > cases where the operator likely isn't intentional. But I couldn't find
> > any, unfortunately.
>
> I was not actually planning on adding the CodeQL workflow to git/git,
> seeing as its CI is already taking way too much CPU time for my liking.
> But in `microsoft/git`, I am kind of required to, so we'll catch those
> issues there.

Heh. I should have read this email from you before replying to the last one ;-).

I would actually be interested in having CodeQL support "ship" for copies of git.git that are hosted on GitHub. I wonder if we could do a similar trick as in a56b6230d0 (ci: add a GitHub workflow to submit Coverity scans, 2023-09-25), where the ENABLE_COVERITY_SCAN_FOR_BRANCHES variable controls whether or not the job actually executes.

Thanks, Taylor