Re: [PATCH v2 09/10] clang: warn when the comma operator is used

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 26, 2025, 08:33 UTC
Message-ID: <Z-O79qs_iL0lYany@pks.im>
In-Reply-To: <9cd9a690-1258-d96d-33c9-53a3b0f346a1@gmx.de>

On Wed, Mar 26, 2025 at 08:50:24AM +0100, Johannes Schindelin wrote:

Show 11 quoted lines

> On Wed, 26 Mar 2025, Patrick Steinhardt wrote:
> > diff --git a/meson.build b/meson.build
> > index dd231b669b6..a7658d62ea0 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -717,6 +717,7 @@ libgit_dependencies = [ ]
> >  # Makefile.
> >  if get_option('warning_level') in ['2','3', 'everything'] and compiler.get_argument_syntax() == 'gcc'
> 
> This `get_argument_syntax() == 'gcc'` condition catches `clang`? What
> other compilers that aren't GCC does it catch?

Yes, it does catch Clang as well as the Intel compiler. The list of compilers and their respective syntax can be found at [1]

Patrick

[1]: https://mesonbuild.com/Reference-tables.html#compiler-ids