Re: [PATCH v3 2/8] ci: fix "fedora-breaking-changes-meson" job
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 14, 2026, 10:35 UTC
- Message-ID
- <as9a3E6NeR_sQeYd@pks.im>
- In-Reply-To
- <20261014091037.GB1341124@coredump.intra.peff.net>
On Wed, Oct 14, 2026 at 05:10:37AM -0400, Jeff King wrote:
Show 23 quoted lines
> On Wed, Oct 14, 2026 at 10:30:28AM +0200, Patrick Steinhardt wrote: > > > The "fedora-breaking-changes-meson" job exercises Git with breaking > > changes enabled on Fedora with Meson. There's a typo in our CI scripts > > though, which has the effect that the build does not enable breaking > > changes by accident. > > > > [...] > > > > case "$jobname" in > > -fedora-breaking-changes-musl|linux-breaking-changes) > > +fedora-breaking-changes-meson|linux-breaking-changes) > > export WITH_BREAKING_CHANGES=YesPlease > > MESONFLAGS="$MESONFLAGS -Dbreaking_changes=true" > > ;; > > Seems obviously correct, but I wonder if just: > > *breaking-changes*) > > would fix this and prevent any issues for possible future jobs. The > downside of a loose pattern is false matches, but it seems like a small > risk given our universe of jobs.
In general I think the way we structure these is somewhat lackluster:
- I never really understood the split between "ci/lib.sh" and
"ci/run-build-and-tests.sh".- There is a bunch of duplication that could be avoided.
- And your suggestion makes sense, too.
I originally carried a patch that merges all of this into "ci/lib.sh", and it also did changes similar to what you propose. We could probably revive that patch, but if so I'd propose to do that as a follow-up.
Patrick