git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 8/8] ci: drop redundant linux-reftable job

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 8, 2026, 18:18 UTC
Message-ID
<xmqqzewoys2h.fsf@gitster.g>
In-Reply-To
<20261008-pks-ci-housekeeping-v1-8-baf015c589c0@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 14 quoted lines
> The "linux-reftable" job exercises Git with reftables as its default
> backend. But this job is arguably redundant because we already have the
> "linux-reftable-leaks" job that exercises reftables with the leak
> sanitizer enabled, and it is unlikely that we will catch any extra bugs
> with the leak sanitizer disabled.
>
> Drop the job.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  .github/workflows/main.yml | 3 ---
>  .gitlab-ci.yml             | 3 ---
>  ci/run-build-and-tests.sh  | 2 +-
>  3 files changed, 1 insertion(+), 7 deletions(-)

As linux-reftable-leaks job uses NO_{CVS,SVN,PR}_TESTS in ci/lib.sh to disable tests on these foreign-scm interoperability tests, this change means reftable is no longer tested with them at all, no?

Not that I personally see specific value in testing git-p4 with both reftable and reffiles backend, the loss of coverage needs to be noted, if not justified, in the proposed commit log message.

Other than that, nice thinking.
Thanks.
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 15 of 27 in “ci: some housekeeping and modernizations”
  1. 0/8 ci: some housekeeping and modernizationsPatrick Steinhardt, Oct 8, 2026
  2. 1/8 t5004: skip SHA-1-only test in SHA-256 repositoryPatrick Steinhardt, Oct 8, 2026
  3. Junio C HamanoOct 8, 2026
  4. Patrick SteinhardtOct 9, 2026
  5. 2/8 ci: fix "fedora-breaking-changes-meson" jobPatrick Steinhardt, Oct 8, 2026
  6. 3/8 ci: drop unused "linux-clang" logicPatrick Steinhardt, Oct 8, 2026
  7. 4/8 ci: switch away from unsupported i386/ubuntu imagePatrick Steinhardt, Oct 8, 2026
  8. Todd ZullingerOct 8, 2026
  9. Junio C HamanoOct 8, 2026
  10. Patrick SteinhardtOct 9, 2026
  11. 5/8 ci: rename linux-TEST-vars jobPatrick Steinhardt, Oct 8, 2026
  12. 6/8 ci: switch away from EOL'd Ubuntu version in linux-exoticPatrick Steinhardt, Oct 8, 2026
  13. 7/8 ci: drop now-dead Python 2 coveragePatrick Steinhardt, Oct 8, 2026
  14. 8/8 ci: drop redundant linux-reftable jobPatrick Steinhardt, Oct 8, 2026
  15. Junio C HamanoOct 8, 2026
  16. Patrick SteinhardtOct 9, 2026
  17. Junio C HamanoOct 9, 2026
  18. 0/8 ci: some housekeeping and modernizationsPatrick Steinhardt, Oct 9, 2026
  19. 1/8 t5004: skip SHA-1-only test in SHA-256 repositoryPatrick Steinhardt, Oct 9, 2026
  20. 2/8 ci: fix "fedora-breaking-changes-meson" jobPatrick Steinhardt, Oct 9, 2026
  21. 3/8 ci: drop unused "linux-clang" logicPatrick Steinhardt, Oct 9, 2026
  22. 4/8 ci: switch away from unsupported i386/ubuntu imagePatrick Steinhardt, Oct 9, 2026
  23. 5/8 ci: rename linux-TEST-vars jobPatrick Steinhardt, Oct 9, 2026
  24. SZEDER GáborOct 9, 2026
  25. 6/8 ci: switch away from EOL'd Ubuntu version in linux-exoticPatrick Steinhardt, Oct 9, 2026
  26. 7/8 ci: drop now-dead Python 2 coveragePatrick Steinhardt, Oct 9, 2026
  27. 8/8 ci: improve reftable test coveragePatrick Steinhardt, Oct 9, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.