Re: [PATCH 8/8] ci: drop redundant linux-reftable job
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 8, 2026, 18:18 UTC
- Message-ID
- <xmqqzewoys2h.fsf@gitster.g>
- In-Reply-To
- <20261008-pks-ci-housekeeping-v1-8-baf015c589c0@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 14 quoted lines
> The "linux-reftable" job exercises Git with reftables as its default > backend. But this job is arguably redundant because we already have the > "linux-reftable-leaks" job that exercises reftables with the leak > sanitizer enabled, and it is unlikely that we will catch any extra bugs > with the leak sanitizer disabled. > > Drop the job. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > .github/workflows/main.yml | 3 --- > .gitlab-ci.yml | 3 --- > ci/run-build-and-tests.sh | 2 +- > 3 files changed, 1 insertion(+), 7 deletions(-)
As linux-reftable-leaks job uses NO_{CVS,SVN,PR}_TESTS in ci/lib.sh to disable tests on these foreign-scm interoperability tests, this change means reftable is no longer tested with them at all, no?
Not that I personally see specific value in testing git-p4 with both reftable and reffiles backend, the loss of coverage needs to be noted, if not justified, in the proposed commit log message.
Other than that, nice thinking.
Thanks.