git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/8] t5004: skip SHA-1-only test in SHA-256 repository

From
Jeff King <peff@peff.net>
Date
Oct 14, 2026, 09:07 UTC
Message-ID
<20261014090746.GA1341124@coredump.intra.peff.net>
In-Reply-To
<20261014-pks-ci-housekeeping-v3-1-04c24e1f480d@pks.im>
On Wed, Oct 14, 2026 at 10:30:27AM +0200, Patrick Steinhardt wrote:
Show 8 quoted lines
> We're about to fix that typo in the next commit, but this will also
> uncover that the above test case is broken when running in SHA-256
> repositories. The extracted objects are SHA-1 objects, so extracting
> them into a SHA-256 repository is not going to yield anything good. So
> once we fix the Fedora-based job to enable breaking changes, which will
> make tests use SHA-256 by default, the test will break.
> 
> Fix this issue by adding the SHA1 prerequisite.

Does that mean we'll basically never run the test once Git 3.0 shifts to sha256 by default? I guess we'll have a sha1 ci job (like we have sha256 today), but would that job actually hit all the other prereqs?

If we instead teach it to use its own repo, independent of the defaults, then we could run it everywhere (that allows all of the other prereqs).

Something like:
diff --git a/t/t5004-archive-corner-cases.sh b/t/t5004-archive-corner-cases.sh
index 768b0ff85d..3a5c01c475 100755
--- a/t/t5004-archive-corner-cases.sh
+++ b/t/t5004-archive-corner-cases.sh
@@ -187,6 +187,9 @@ test_expect_success EXPENSIVE,UNZIP,UNZIP_ZIP64_SUPPORT \
 
 test_expect_success EXPENSIVE,LONG_IS_64BIT,UNZIP,UNZIP_ZIP64_SUPPORT,ZIPINFO \
 	'zip archive with files bigger than 4GB' '
+	git init --object-format=sha1 big-file &&
+	(
+	cd big-file &&
 	# Pack created with:
 	#   dd if=/dev/zero of=file bs=1M count=4100 && git hash-object -w file
 	mkdir -p .git/objects/pack &&
@@ -206,6 +209,7 @@ test_expect_success EXPENSIVE,LONG_IS_64BIT,UNZIP,UNZIP_ZIP64_SUPPORT,ZIPINFO \
 	"$GIT_UNZIP" -t big.zip &&
 	"$ZIPINFO" big.zip >big.lst &&
 	test_grep $size big.lst
+	)
 '
 
 build_tree() {


A real patch obviously would also indent the test body one level; I
skipped that here to keep the diff readable.

-Peff
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 33 of 77 in “ci: some housekeeping and modernizations”
  1. 0/8 ci: some housekeeping and modernizationsPatrick Steinhardt, Oct 8, 2026
  2. 1/8 t5004: skip SHA-1-only test in SHA-256 repositoryPatrick Steinhardt, Oct 8, 2026
  3. Junio C HamanoOct 8, 2026
  4. Patrick SteinhardtOct 9, 2026
  5. 2/8 ci: fix "fedora-breaking-changes-meson" jobPatrick Steinhardt, Oct 8, 2026
  6. 3/8 ci: drop unused "linux-clang" logicPatrick Steinhardt, Oct 8, 2026
  7. 4/8 ci: switch away from unsupported i386/ubuntu imagePatrick Steinhardt, Oct 8, 2026
  8. Todd ZullingerOct 8, 2026
  9. Junio C HamanoOct 8, 2026
  10. Patrick SteinhardtOct 9, 2026
  11. 5/8 ci: rename linux-TEST-vars jobPatrick Steinhardt, Oct 8, 2026
  12. 6/8 ci: switch away from EOL'd Ubuntu version in linux-exoticPatrick Steinhardt, Oct 8, 2026
  13. 7/8 ci: drop now-dead Python 2 coveragePatrick Steinhardt, Oct 8, 2026
  14. 8/8 ci: drop redundant linux-reftable jobPatrick Steinhardt, Oct 8, 2026
  15. Junio C HamanoOct 8, 2026
  16. Patrick SteinhardtOct 9, 2026
  17. Junio C HamanoOct 9, 2026
  18. 0/8 ci: some housekeeping and modernizationsPatrick Steinhardt, Oct 9, 2026
  19. 1/8 t5004: skip SHA-1-only test in SHA-256 repositoryPatrick Steinhardt, Oct 9, 2026
  20. 2/8 ci: fix "fedora-breaking-changes-meson" jobPatrick Steinhardt, Oct 9, 2026
  21. 3/8 ci: drop unused "linux-clang" logicPatrick Steinhardt, Oct 9, 2026
  22. 4/8 ci: switch away from unsupported i386/ubuntu imagePatrick Steinhardt, Oct 9, 2026
  23. 5/8 ci: rename linux-TEST-vars jobPatrick Steinhardt, Oct 9, 2026
  24. SZEDER GáborOct 9, 2026
  25. Patrick SteinhardtOct 13, 2026
  26. Junio C HamanoOct 13, 2026
  27. Patrick SteinhardtOct 14, 2026
  28. 6/8 ci: switch away from EOL'd Ubuntu version in linux-exoticPatrick Steinhardt, Oct 9, 2026
  29. 7/8 ci: drop now-dead Python 2 coveragePatrick Steinhardt, Oct 9, 2026
  30. 8/8 ci: improve reftable test coveragePatrick Steinhardt, Oct 9, 2026
  31. 0/8 ci: some housekeeping and modernizationsPatrick Steinhardt, Oct 14, 2026
  32. 1/8 t5004: skip SHA-1-only test in SHA-256 repositoryPatrick Steinhardt, Oct 14, 2026
  33. Jeff KingOct 14, 2026
  34. Patrick SteinhardtOct 14, 2026
  35. Kaartic SivaraamOct 14, 2026
  36. Patrick SteinhardtOct 15, 2026
  37. 2/8 ci: fix "fedora-breaking-changes-meson" jobPatrick Steinhardt, Oct 14, 2026
  38. Jeff KingOct 14, 2026
  39. Patrick SteinhardtOct 14, 2026
  40. Jeff KingOct 14, 2026
  41. Patrick SteinhardtOct 14, 2026
  42. 3/8 ci: drop unused "linux-clang" logicPatrick Steinhardt, Oct 14, 2026
  43. 4/8 ci: switch away from unsupported i386/ubuntu imagePatrick Steinhardt, Oct 14, 2026
  44. Jeff KingOct 14, 2026
  45. Patrick SteinhardtOct 14, 2026
  46. Jeff KingOct 14, 2026
  47. 5/8 ci: rename linux-TEST-vars jobPatrick Steinhardt, Oct 14, 2026
  48. Jeff KingOct 14, 2026
  49. 6/8 ci: switch away from EOL'd Ubuntu version in linux-feature-testbedPatrick Steinhardt, Oct 14, 2026
  50. Jeff KingOct 14, 2026
  51. 7/8 ci: drop now-dead Python 2 coveragePatrick Steinhardt, Oct 14, 2026
  52. 8/8 ci: improve reftable test coveragePatrick Steinhardt, Oct 14, 2026
  53. Jeff KingOct 14, 2026
  54. Patrick SteinhardtOct 14, 2026
  55. Jeff KingOct 14, 2026
  56. Patrick SteinhardtOct 14, 2026
  57. Jeff KingOct 14, 2026
  58. Jeff KingOct 14, 2026
  59. Junio C HamanoOct 14, 2026
  60. Patrick SteinhardtOct 15, 2026
  61. Junio C HamanoOct 15, 2026
  62. 0/8 ci: some housekeeping and modernizationsPatrick Steinhardt, Oct 15, 2026
  63. 1/8 t5004: fix test creating an archive with large objects under SHA256Patrick Steinhardt, Oct 15, 2026
  64. 2/8 ci: fix "fedora-breaking-changes-meson" jobPatrick Steinhardt, Oct 15, 2026
  65. 3/8 ci: drop unused "linux-clang" logicPatrick Steinhardt, Oct 15, 2026
  66. Kaartic SivaraamOct 15, 2026
  67. Patrick SteinhardtOct 15, 2026
  68. Junio C HamanoOct 16, 2026
  69. Patrick SteinhardtOct 19, 2026
  70. Junio C HamanoOct 19, 2026
  71. 4/8 ci: switch away from unsupported i386/ubuntu imagePatrick Steinhardt, Oct 15, 2026
  72. 5/8 ci: rename linux-TEST-vars jobPatrick Steinhardt, Oct 15, 2026
  73. 6/8 ci: switch away from EOL'd Ubuntu version in linux-feature-testbedPatrick Steinhardt, Oct 15, 2026
  74. 7/8 ci: drop now-dead Python 2 coveragePatrick Steinhardt, Oct 15, 2026
  75. 8/8 ci: improve reftable test coveragePatrick Steinhardt, Oct 15, 2026
  76. Jeff KingOct 15, 2026
  77. Junio C HamanoOct 15, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.