Re: [PATCH v2 5/8] ci: rename linux-TEST-vars job
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 13, 2026, 07:21 UTC
- Message-ID
- <as3b-u7SzE3uPwQx@pks.im>
- In-Reply-To
- <askI1DGldZx8ElIN@szeder.dev>
On Fri, Oct 09, 2026 at 05:31:32PM +0200, SZEDER Gábor wrote:
Show 13 quoted lines
> On Fri, Oct 09, 2026 at 01:32:02PM +0200, Patrick Steinhardt wrote: > > The "linux-TEST-vars" job exercises Git with a bunch of non-default > > options enabled. The name of that job makes you want to cry though due > > to the weird upper-casing > > Yeah, it's an eyesore indeed. > > > and because it doesn't really tell you what it > > even intends to do. > > It intends to set a bunch of GIT_TEST_* variables, and since it has > test vars in its name, I'd say that it does a decent job at conveying > its intentions.
That only tells you anything in case you evne know about the GIT_TEST variariables, but doesn't really give you much of an idea what the intent of that job is. But...
Show 8 quoted lines
> > Rename the job to "linux-exotic" instead. > > Seeing "linux-exotic", I would think of a job running tests on an > exotic Linux distro, or on an exotic platform... but it wouldn't > occur to me that it intends to set a bunch of GIT_TEST_* variables, > simply because there is nothing in its name to indicate that. > > I think this patch makes things worse.
... I think it's still a fair point. The question is whether we can come up with a better name then that is not an eyesore and that gives you a clue what the job is doing without you having to know about the underlying mechanism.
A couple of names that come to my mind would be "linux-nondefault", "linux-optional-features"... and not much else. Do you have any suggestions?
Thanks!
Patrick