Re: [PATCH v2] gc: call "prune --expire 2.weeks.ago" by default
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 12, 2008, 19:38 UTC
- Message-ID
- <alpine.LSU.1.00.0803122035580.1656@racer.site>
- In-Reply-To
- <7viqzr69ka.fsf@gitster.siamese.dyndns.org>
Hi,
On Wed, 12 Mar 2008, Junio C Hamano wrote:
Show 6 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > Okay, so I just remove the !approxidate() check. Then, "gc.pruneExpire = > > never" should work as you expect it to. > > Huh? date.c::special[] has "never" defined for this exact reason.
Oops. I thought that approxidate() returns 0 on error, but apparently this is not so. Instead, it returns "now"!
So first of all, my patch is incorrect, and second: invalid dates cannot be caught reliably.
Darn.
Ciao, Dscho "who'll think about a way around that"