Re: [PATCH v4] gc: call "prune --expire 2.weeks.ago" by default
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 12, 2008, 23:13 UTC
- Message-ID
- <7vzlt335a5.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <alpine.LSU.1.00.0803122348210.1656@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 19 quoted lines
>> Yuck; approxidate() returns ulong. Can subtracting a ulong from another
>> ever go negative?
>>
>> Besides, because there is no guarantee of the order of evaluation between
>> these two approxidate() calls, you may get +1 or -1 on the second boundary.
>>
>> I think the reason why you did not catch it in your test is because your
>> tests are half complete; they test only what you wanted to catch
>> (misconfigured case) and do not test the other half (properly working
>> case).
>
> Yes, probably. Of course, comparing a difference to 0 is absolutely
> moronic.
>
> I should have written
>
> approxidate(value) >= approxidate("now"))
>
> in the first place.Eh, sorry, but why?
> So, could you tell me, please, if I should resend the patch with your > --prune documentation, or without?
I like Nico's suggestion to put that "historical notes" in RelNotes, so the documentation part is fine as is.