git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] gc: call "prune --expire 2.weeks.ago" by default

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 12, 2008, 23:13 UTC
Message-ID
<7vzlt335a5.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.LSU.1.00.0803122348210.1656@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 19 quoted lines
>> Yuck; approxidate() returns ulong.  Can subtracting a ulong from another
>> ever go negative?
>> 
>> Besides, because there is no guarantee of the order of evaluation between
>> these two approxidate() calls, you may get +1 or -1 on the second boundary.
>> 
>> I think the reason why you did not catch it in your test is because your
>> tests are half complete; they test only what you wanted to catch
>> (misconfigured case) and do not test the other half (properly working
>> case).
>
> Yes, probably.  Of course, comparing a difference to 0 is absolutely 
> moronic.
>
> I should have written
>
> 				approxidate(value) >= approxidate("now"))
>
> in the first place.
Eh, sorry, but why?
> So, could you tell me, please, if I should resend the patch with your 
> --prune documentation, or without?

I like Nico's suggestion to put that "historical notes" in RelNotes, so the documentation part is fine as is.

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 34 of 41 in “gc: call "prune --expire 2.weeks.ago"”
  1. gc: call "prune --expire 2.weeks.ago"Johannes Schindelin, Mar 11, 2008
  2. Junio C HamanoMar 12, 2008
  3. Nicolas PitreMar 12, 2008
  4. Junio C HamanoMar 12, 2008
  5. Johannes SchindelinMar 12, 2008
  6. Nicolas PitreMar 12, 2008
  7. Pieter de BieMar 12, 2008
  8. Johannes SchindelinMar 12, 2008
  9. Jeff KingMar 12, 2008
  10. Pieter de BieMar 12, 2008
  11. Junio C HamanoMar 12, 2008
  12. Johannes SchindelinMar 12, 2008
  13. Junio C HamanoMar 12, 2008
  14. Geert BoschMar 12, 2008
  15. Nicolas PitreMar 12, 2008
  16. Marko KreenMar 12, 2008
  17. gc: call "prune --expire 2.weeks.ago" by defaultJohannes Schindelin, Mar 12, 2008
  18. Brandon CaseyMar 12, 2008
  19. Jakub NarebskiMar 12, 2008
  20. Johannes SchindelinMar 12, 2008
  21. Junio C HamanoMar 12, 2008
  22. Johannes SchindelinMar 12, 2008
  23. gc: call "prune --expire 2.weeks.ago" by defaultJohannes Schindelin, Mar 12, 2008
  24. Johannes SchindelinMar 12, 2008
  25. Brandon CaseyMar 12, 2008
  26. Johannes SchindelinMar 12, 2008
  27. Brandon CaseyMar 12, 2008
  28. Junio C HamanoMar 12, 2008
  29. gc: call "prune --expire 2.weeks.ago" by defaultJohannes Schindelin, Mar 12, 2008
  30. Johannes SchindelinMar 12, 2008
  31. Junio C HamanoMar 12, 2008
  32. Nicolas PitreMar 12, 2008
  33. Johannes SchindelinMar 12, 2008
  34. Junio C HamanoMar 12, 2008
  35. Johannes SchindelinMar 12, 2008
  36. Junio C HamanoMar 12, 2008
  37. Johannes SchindelinMar 12, 2008
  38. Wincent ColaiutaMar 13, 2008
  39. Johannes SixtMar 13, 2008
  40. Wincent ColaiutaMar 13, 2008
  41. Johannes SchindelinMar 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.