Re: [PATCH] gc: call "prune --expire 2.weeks.ago"

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 12, 2008, 23:20 UTC
Message-ID: <7vtzjb34y0.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <B27EC8CF-482D-499B-B4E0-019049926C93@ai.rug.nl>

Pieter de Bie <pdebie@ai.rug.nl> writes:

Show 17 quoted lines

> On Mar 12, 2008, at 6:01 PM, Jeff King wrote:
>
>> On Wed, Mar 12, 2008 at 05:05:51PM +0100, Johannes Schindelin wrote:
>>
>>>> I'd really like it to be at least 2 weeks
>>>
>>> Could you back that up with an explanation, as to why?
>>
>> I assume it's "because I wouldn't want to lose work I had done within
>> the last two weeks." Yes, I know that this expiration is actually
>> after
>> the reflog has already expired
>
> Ah, I hadn't realised that. Then I don't really care, one week sounds
> fine too. 2 weeks just seemed a bit short, as the default reflog is 30
> days. But if it's 2 weeks after the 30 days, that should be more than
> enough

Wasn't the default 90 days?

In any case, after 90 days, my reading of the code is that these loose ones become unreachable, and when we look at their timestamps, we notice that they are already more than 2 weeks old, and they will immediately be removed.

So it won't be "2 weeks after X", either.