Re: [PATCH] gc: call "prune --expire 2.weeks.ago"

From: Nicolas Pitre <nico@cam.org>
Date: Mar 12, 2008, 02:37 UTC
Message-ID: <alpine.LFD.1.00.0803112234470.2947@xanadu.home>
In-Reply-To: <7vskywadum.fsf@gitster.siamese.dyndns.org>

On Tue, 11 Mar 2008, Junio C Hamano wrote:

Show 17 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > If "--prune" is passed to gc, it still just calls "git prune".
> > Otherwise, "prune --expire 2.weeks.ago" is called, where the grace
> > period is overrideable by the config variable gc.pruneExpire.
> 
> "What it does."
> 
> > While adding a test to t5304-prune.sh (since it really tests the
> > implicit call to "prune"), the original test for "prune --expire"
> > is moved there from t1410-reflog.sh, where it did not belong.
> 
> "What the fallouts from this change were."
> 
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> Can we also have "why this is a good idea", "what problem this solves"?

FWIW, my agreeing with the "why this is a good idea" can be translated into:

Acked-by: Nicolas Pitre <nico@cam.org>

Nicolas