git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC,PATCH] Make git prune remove temporary packs that look like write failures

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 4, 2008, 15:16 UTC
Message-ID
<alpine.LSU.1.00.0802041512140.7372@racer.site>
In-Reply-To
<e1dab3980802040610s27a54a9due3b42db5f59c0cd5@mail.gmail.com>
Hi,
On Mon, 4 Feb 2008, David Tweed wrote:
> +                       if(c>0 && c<4096 && stat(name, &status) == 0
> +                          && status.st_mtime < now - 600){

Please have spaces after the "if" and before the "{" (just imitate the style of the rest of the file).

Also, 10 minutes grace period for any ongoing fetch or repack seems a bit arbitrary. Maybe default to 10 minutes, and introduce prune.packGracePeriod?

(Which reminds me that it might be useful to add a prune.looseObjectsGracePeriod to avoid having to type --expire= all the time?)

Ciao, Dscho

Previous: Nicolas PitreNext: David Tweed
Message 3 of 11 in “Make git prune remove temporary packs that look like write failures”
  1. Make git prune remove temporary packs that look like write failuresDavid Tweed, Feb 4, 2008
  2. Nicolas PitreFeb 4, 2008
  3. Johannes SchindelinFeb 4, 2008
  4. David TweedFeb 4, 2008
  5. Johannes SchindelinFeb 4, 2008
  6. David TweedFeb 4, 2008
  7. David TweedFeb 4, 2008
  8. Nicolas PitreFeb 4, 2008
  9. David TweedFeb 4, 2008
  10. Nicolas PitreFeb 4, 2008
  11. Johannes SchindelinFeb 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.