git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC,PATCH] Make git prune remove temporary packs that look like write failures

From
DTDavid Tweed <david.tweed@gmail.com>
Date
Feb 4, 2008, 17:39 UTC
Message-ID
<e1dab3980802040939u1329ab6xa730f5ecc52c809a@mail.gmail.com>
In-Reply-To
<alpine.LSU.1.00.0802041714560.7372@racer.site>
On Feb 4, 2008 5:21 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> On Mon, 4 Feb 2008, David Tweed wrote:
Show 5 quoted lines
> > In response to this and to Nico's earlier mail, I _think_ the usage with
> > repack is completely safe.
>
> It would have been nicer of you to defend that, instead of sending me off
> to look for myself.  Having looked for myself, I am not convinced at all.

I probably ought to have put the underlines around the "I". I'm convinced, but since this is deleting things I'm more cautious than I would be, say, parsing options.

> And it would have been surprising: if your patch would play nicely with a
> repack in progress, then it would fail to remove the temporary packs left
> by a crashed repack.

I should been more careful what I said: I only use repack via "git gc" which calls the repack as a subcommand. If the repack fails then the whole process dies and you've got a dead tmp pack. The _next_ time you call "git gc" it will do the repack, finish and then call "git prune" (assuming --prune) and delete the temporary pack. Used in this way, I have tried and I cannot see an execution path where this can go wrong. You're right (and I didn't intend to suggest otherwise) that it would be safe when running a "git prune" concurrently with a separate "git repack".

However, I'm not familiar with what things like git-svn, cvs, etc, do. Given that I've seen patches adding "git gc" periodically during various imports, I wanted to someone who knows that area to confirm the patch isn't violating any assumptions.

-- 
cheers, dave tweed__________________________
david.tweed@gmail.com
Rm 124, School of Systems Engineering, University of Reading.
"while having code so boring anyone can maintain it, use Python." --
attempted insult seen on slashdot
Previous: Johannes SchindelinNext: David Tweed
Message 6 of 11 in “Make git prune remove temporary packs that look like write failures”
  1. Make git prune remove temporary packs that look like write failuresDavid Tweed, Feb 4, 2008
  2. Nicolas PitreFeb 4, 2008
  3. Johannes SchindelinFeb 4, 2008
  4. David TweedFeb 4, 2008
  5. Johannes SchindelinFeb 4, 2008
  6. David TweedFeb 4, 2008
  7. David TweedFeb 4, 2008
  8. Nicolas PitreFeb 4, 2008
  9. David TweedFeb 4, 2008
  10. Nicolas PitreFeb 4, 2008
  11. Johannes SchindelinFeb 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.