Re: [RFC,PATCH] Make git prune remove temporary packs that look like write failures

From: Nicolas Pitre <nico@cam.org>
Date: Feb 4, 2008, 16:06 UTC
Message-ID: <alpine.LFD.1.00.0802041105170.2732@xanadu.home>
In-Reply-To: <alpine.LSU.1.00.0802041512140.7372@racer.site>

On Mon, 4 Feb 2008, Johannes Schindelin wrote:

Show 17 quoted lines

> Hi,
> 
> On Mon, 4 Feb 2008, David Tweed wrote:
> 
> > +                       if(c>0 && c<4096 && stat(name, &status) == 0
> > +                          && status.st_mtime < now - 600){
> 
> Please have spaces after the "if" and before the "{" (just imitate the 
> style of the rest of the file).
> 
> Also, 10 minutes grace period for any ongoing fetch or repack seems a bit 
> arbitrary.  Maybe default to 10 minutes, and introduce 
> prune.packGracePeriod?
> 
> (Which reminds me that it might be useful to add a 
> prune.looseObjectsGracePeriod to avoid having to type --expire= all the 
> time?)

Please use the same parameter for both. There is no need to have separate settings.

Nicolas