Re: [RFC,PATCH] Make git prune remove temporary packs that look like write failures
- From
- David Tweed <david.tweed@gmail.com>
- Date
- Feb 4, 2008, 15:24 UTC
- Message-ID
- <e1dab3980802040724l5ef12528y69f1d572b7ac8d54@mail.gmail.com>
- In-Reply-To
- <alpine.LSU.1.00.0802041512140.7372@racer.site>
On Feb 4, 2008 3:16 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 13 quoted lines
> Hi,
>
> On Mon, 4 Feb 2008, David Tweed wrote:
>
> > + if(c>0 && c<4096 && stat(name, &status) == 0
> > + && status.st_mtime < now - 600){
>
> Please have spaces after the "if" and before the "{" (just imitate the
> style of the rest of the file).
>
> Also, 10 minutes grace period for any ongoing fetch or repack seems a bit
> arbitrary. Maybe default to 10 minutes, and introduce
> prune.packGracePeriod?In response to this and to Nico's earlier mail, I _think_ the usage with repack is completely safe. What I'm not sure about is that other things like git-svn create temporary packs with usage/semantics I'm not sure about. I'm happy to delete immediately if those who understand the interactions in the whole of git say that's acceptable when the user specifically calls git-prune.
-- cheers, dave tweed__________________________ david.tweed@gmail.com Rm 124, School of Systems Engineering, University of Reading. "while having code so boring anyone can maintain it, use Python." -- attempted insult seen on slashdot