From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 04 Feb 2008 15:16:12 GMT
Subject: Re: [RFC,PATCH] Make git prune remove temporary packs that look like write failures
Message-ID: <alpine.LSU.1.00.0802041512140.7372@racer.site>
In-Reply-To: <e1dab3980802040610s27a54a9due3b42db5f59c0cd5@mail.gmail.com>

Hi,

On Mon, 4 Feb 2008, David Tweed wrote:

> +                       if(c>0 && c<4096 && stat(name, &status) == 0
> +                          && status.st_mtime < now - 600){

Please have spaces after the "if" and before the "{" (just imitate the 
style of the rest of the file).

Also, 10 minutes grace period for any ongoing fetch or repack seems a bit 
arbitrary.  Maybe default to 10 minutes, and introduce 
prune.packGracePeriod?

(Which reminds me that it might be useful to add a 
prune.looseObjectsGracePeriod to avoid having to type --expire= all the 
time?)

Ciao,
Dscho