git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add platform-independent .git "symlink"

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 3, 2008, 01:55 UTC
Message-ID
<alpine.LSU.1.00.0802030155240.7372@racer.site>
In-Reply-To
<8c5c35580802021047o41a7de9fi84a6b33f0f779e2e@mail.gmail.com>
Hi,
On Sat, 2 Feb 2008, Lars Hjemli wrote:
Show 14 quoted lines
> On Feb 2, 2008 7:19 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>
> > On Sat, 2 Feb 2008, Lars Hjemli wrote:
> >
> > > +     if (len < 10 || buf[len - 1] != '\n' || strncmp(buf, "GITDIR: ", 8))
> >
> > Sorry, missed that earlier: How about
> >
> >         if (!len || buf[len-1] != '\n' || prefixcmp(buf, "GITDIR: "))
> >
> > instead?  (buf does not need be NUL terminated for the prefixcmp(), since
> > we just made sure it is LF terminated)
> 
> That's true, although it feels a bit too clever for me ;-)
:-)
Show 9 quoted lines
> Maybe this as a compromise?
> 
> 	static char buf[PATH_MAX + 9];  /* "GITDIR: " + "\n"  */
> ...
> 	if (!len || buf[len - 1] != '\n')
> 		return NULL;
> 	buf[len - 1] = '\0';
> 	if (prefixcmp(buf, "GITDIR: "))
> 		return NULL;
Sure!

Thanks, Dscho

Previous: Lars HjemliNext: Junio C Hamano
Message 22 of 29 in “Add platform-independent .git "symlink"”
  1. Add platform-independent .git "symlink"Lars Hjemli, Feb 2, 2008
  2. Add tests for .git fileLars Hjemli, Feb 2, 2008
  3. Johannes SchindelinFeb 2, 2008
  4. Lars HjemliFeb 2, 2008
  5. Add platform-independent .git "symlink"Lars Hjemli, Feb 2, 2008
  6. Johannes SchindelinFeb 2, 2008
  7. Johannes SchindelinFeb 2, 2008
  8. Shawn O. PearceFeb 4, 2008
  9. Junio C HamanoFeb 4, 2008
  10. Johannes SchindelinFeb 4, 2008
  11. Brandon CaseyFeb 4, 2008
  12. Johannes SchindelinFeb 4, 2008
  13. Brandon CaseyFeb 4, 2008
  14. Johannes SchindelinFeb 4, 2008
  15. Brandon CaseyFeb 4, 2008
  16. Brandon CaseyFeb 4, 2008
  17. Johannes SchindelinFeb 5, 2008
  18. Johannes SchindelinFeb 5, 2008
  19. Brandon CaseyFeb 5, 2008
  20. Johannes SchindelinFeb 5, 2008
  21. Lars HjemliFeb 2, 2008
  22. Johannes SchindelinFeb 3, 2008
  23. Junio C HamanoFeb 4, 2008
  24. Johannes SchindelinFeb 4, 2008
  25. Shawn O. PearceFeb 4, 2008
  26. Junio C HamanoFeb 4, 2008
  27. Shawn O. PearceFeb 4, 2008
  28. Lars HjemliFeb 4, 2008
  29. Johannes SchindelinFeb 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.