Re: [PATCH] Add platform-independent .git "symlink"

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 4, 2008, 01:35 UTC
Message-ID: <20080204013559.GE24004@spearce.org>
In-Reply-To: <alpine.LSU.1.00.0802040024030.7372@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 21 quoted lines

> On Sun, 3 Feb 2008, Junio C Hamano wrote:
> 
> > "Lars Hjemli" <hjemli@gmail.com> writes:
> > 
> > > Maybe this as a compromise?
> > >
> > > 	static char buf[PATH_MAX + 9];  /* "GITDIR: " + "\n"  */
> > > ...
> > > 	if (!len || buf[len - 1] != '\n')
> > > 		return NULL;
> > > 	buf[len - 1] = '\0';
> > > 	if (prefixcmp(buf, "GITDIR: "))
> > > 		return NULL;
> > 
> > Perhaps that is easier to read.
> > 
> > For now I haven't picked up any of the "how about this way"
> > revisions.
> 
> Yeah, I think all my comments have been addressed...  Lars, care to send a 
> new version?

I would suggest a slightly different name, "GIT_DIR: ", as the line prefix, because the environment variable is also GIT_DIR.

But that's just me.

-- 
Shawn.