Re: [PATCH] Add platform-independent .git "symlink"

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 4, 2008, 02:00 UTC
Message-ID: <20080204020032.GI24004@spearce.org>
In-Reply-To: <7vr6fto5oe.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

Show 16 quoted lines

> "Shawn O. Pearce" <spearce@spearce.org> writes:
> >
> > I would suggest a slightly different name, "GIT_DIR: ", as the
> > line prefix, because the environment variable is also GIT_DIR.
> >
> > But that's just me.
> 
> I think that was modelled after symref HEAD that would point at
> the real ref with "ref: refs/heads/master", as if you have a
> symlink whose value is "refs/heads/master".  So reusing "ref: "
> might be Ok, and saying "directory: " or "gitdir: " would be
> also Ok.
> 
> If we would want to reuse the mechanism in the future to allow
> symlink challenged systems to use it in contrib/workdir/, we may
> want to keep the name a bit more generic than "gitdir: ".

I could easily get behind "gitdir: " or "directory: ". Both are all lowercase, and thus look a lot like "ref: ", which already has been in heavy use for quite some time.

But "GITDIR: " isn't very close to GIT_DIR (its environment based sister) or "ref: " (its file based very-distant cousin).

As a bike-shed painter I like to keep colors matching when possible.

:-)

-- 
Shawn.