git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add gitattributes file making whitespace checking pickier

From
Daniel Barkalow <barkalow@iabervon.org>
Date
Feb 10, 2008, 20:22 UTC
Message-ID
<alpine.LNX.1.00.0802101502320.13593@iabervon.org>
In-Reply-To
<7vabm9gk1p.fsf@gitster.siamese.dyndns.org>
On Sun, 10 Feb 2008, Junio C Hamano wrote:
Show 6 quoted lines
> I've tried "unexpand | expand" to Documentation/*.txt and
> compared the formatted documentation before and after the
> change, and as we suspected everything seems to match.
> 
> So I am considering applying this patch.  We may want to tighten
> it later but as the initial set of rules this should do.

I think it's worthwhile to note that some of the files under t/ have whitespace that doesn't conform to the rest of the project. This would include anything with a email signature break marker (line consisting of "-- "), as well as patches with non-standard whitespace used for testing whitespace checking, and (I think) correct patches with blank lines as context. It's possible that we want to declare all of t/ as binary, at least initially, in the theory that we want to test with exact byte sequence expectations and inputs.

On the other hand, I think this patch is an odd combination of stuff; aren't the contrib exceptions not exceptional, since only *.[ch] and *.txt gets declared as "whitespace"?

	-Daniel
*This .sig left intentionally blank*
Previous: J. Bruce FieldsNext: Junio C Hamano
Message 17 of 22 in “Add gitattributes file making whitespace checking pickier”
  1. Add gitattributes file making whitespace checking pickierJ. Bruce Fields, Feb 9, 2008
  2. Daniel BarkalowFeb 9, 2008
  3. J. Bruce FieldsFeb 9, 2008
  4. J. Bruce FieldsFeb 9, 2008
  5. Jakub NarebskiFeb 9, 2008
  6. J. Bruce FieldsFeb 9, 2008
  7. Jakub NarebskiFeb 9, 2008
  8. J. Bruce FieldsFeb 9, 2008
  9. Junio C HamanoFeb 9, 2008
  10. J. Bruce FieldsFeb 9, 2008
  11. Jakub NarebskiFeb 9, 2008
  12. Junio C HamanoFeb 10, 2008
  13. Jakub NarebskiFeb 10, 2008
  14. Junio C HamanoFeb 10, 2008
  15. Add gitattributes file making whitespace checking pickierJunio C Hamano, Feb 10, 2008
  16. J. Bruce FieldsFeb 10, 2008
  17. Daniel BarkalowFeb 10, 2008
  18. Junio C HamanoFeb 10, 2008
  19. Daniel BarkalowFeb 10, 2008
  20. Junio C HamanoFeb 11, 2008
  21. Brian DowningFeb 12, 2008
  22. Junio C HamanoFeb 12, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.