From: Daniel Barkalow Date: Sun, 10 Feb 2008 20:22:17 GMT Subject: Re: [PATCH] Add gitattributes file making whitespace checking pickier Message-ID: In-Reply-To: <7vabm9gk1p.fsf@gitster.siamese.dyndns.org> On Sun, 10 Feb 2008, Junio C Hamano wrote: > I've tried "unexpand | expand" to Documentation/*.txt and > compared the formatted documentation before and after the > change, and as we suspected everything seems to match. > > So I am considering applying this patch. We may want to tighten > it later but as the initial set of rules this should do. I think it's worthwhile to note that some of the files under t/ have whitespace that doesn't conform to the rest of the project. This would include anything with a email signature break marker (line consisting of "-- "), as well as patches with non-standard whitespace used for testing whitespace checking, and (I think) correct patches with blank lines as context. It's possible that we want to declare all of t/ as binary, at least initially, in the theory that we want to test with exact byte sequence expectations and inputs. On the other hand, I think this patch is an odd combination of stuff; aren't the contrib exceptions not exceptional, since only *.[ch] and *.txt gets declared as "whitespace"? -Daniel *This .sig left intentionally blank*