git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add gitattributes file making whitespace checking pickier

From
JFJ. Bruce Fields <bfields@fieldses.org>
Date
Feb 10, 2008, 18:56 UTC
Message-ID
<20080210185649.GB8267@fieldses.org>
In-Reply-To
<7vabm9gk1p.fsf@gitster.siamese.dyndns.org>
On Sun, Feb 10, 2008 at 02:52:50AM -0800, Junio C Hamano wrote:
> I've tried "unexpand | expand" to Documentation/*.txt and
> compared the formatted documentation before and after the
> change, and as we suspected everything seems to match.
Thanks for testing that.
> So I am considering applying this patch.  We may want to tighten
> it later but as the initial set of rules this should do.
No objections from me.--b.
Show 50 quoted lines
> 
> -- >8 --
> [PATCH] Add gitattributes file making whitespace checking pickier
> 
> This establishes what the "bad" whitespaces are for this
> project.
> 
> The rules are:
> 
>  - For C source files, trailing whitespaces, an HT that follows
>    a SP in the leading indent, and initial indent by SP that can
>    be replaced with HT are all bad.
> 
>  - The same rule applies to the AsciiDoc input files in the
>    Documentation/ hierarchy.
> 
>  - It is Ok to indent with all spaces the Python and Elisp
>    sources in the contrib/ area.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> 
>  .gitattributes               |    1 +
>  Documentation/.gitattributes |    1 +
>  contrib/.gitattributes       |    3 +++
>  3 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/.gitattributes b/.gitattributes
> new file mode 100644
> index 0000000..9dd769a
> --- /dev/null
> +++ b/.gitattributes
> @@ -0,0 +1 @@
> +*.[ch] whitespace
> diff --git a/Documentation/.gitattributes b/Documentation/.gitattributes
> new file mode 100644
> index 0000000..ddb0301
> --- /dev/null
> +++ b/Documentation/.gitattributes
> @@ -0,0 +1 @@
> +*.txt whitespace
> diff --git a/contrib/.gitattributes b/contrib/.gitattributes
> new file mode 100644
> index 0000000..2b48d05
> --- /dev/null
> +++ b/contrib/.gitattributes
> @@ -0,0 +1,3 @@
> +*.py whitespace=!indent,trail,space
> +*.el whitespace=!indent,trail,space
> +fast-import/git-p4 whitespace=!indent,trail,space
Previous: Junio C HamanoNext: Daniel Barkalow
Message 16 of 22 in “Add gitattributes file making whitespace checking pickier”
  1. Add gitattributes file making whitespace checking pickierJ. Bruce Fields, Feb 9, 2008
  2. Daniel BarkalowFeb 9, 2008
  3. J. Bruce FieldsFeb 9, 2008
  4. J. Bruce FieldsFeb 9, 2008
  5. Jakub NarebskiFeb 9, 2008
  6. J. Bruce FieldsFeb 9, 2008
  7. Jakub NarebskiFeb 9, 2008
  8. J. Bruce FieldsFeb 9, 2008
  9. Junio C HamanoFeb 9, 2008
  10. J. Bruce FieldsFeb 9, 2008
  11. Jakub NarebskiFeb 9, 2008
  12. Junio C HamanoFeb 10, 2008
  13. Jakub NarebskiFeb 10, 2008
  14. Junio C HamanoFeb 10, 2008
  15. Add gitattributes file making whitespace checking pickierJunio C Hamano, Feb 10, 2008
  16. J. Bruce FieldsFeb 10, 2008
  17. Daniel BarkalowFeb 10, 2008
  18. Junio C HamanoFeb 10, 2008
  19. Daniel BarkalowFeb 10, 2008
  20. Junio C HamanoFeb 11, 2008
  21. Brian DowningFeb 12, 2008
  22. Junio C HamanoFeb 12, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.