git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add gitattributes file making whitespace checking pickier

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 10, 2008, 21:52 UTC
Message-ID
<7v3as0fpib.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200802101231.16847.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 7 quoted lines
> Junio C Hamano wrote:
>> Jakub Narebski <jnareb@gmail.com> writes:
>> 
>>>> *.py whitespace=!indent,trail,space
>>>> *.el whitespace=!indent,trail,space
>
> Emacs Lisp is (like Perl, and contrary to Python) whitespace agnostic,
What does agnostic have anything to do with anything?

C is whitespace agnostic and outside obvious places like string constants and #preprocessor directives you can have SP and HT and LF interchangeably. It does not mean you do not need whitespace policy.

If gitweb historically used SP everywhere like git.el, I think that is a very good reason to treat it just like *.py and *.el, though. See the updated set of patterns I sent to Daniel just now.

Show 7 quoted lines
>> It also happens that I do not personally believe in "alignment
>> with spaces" argument.  If you accept W and a SP occupy the same
>> horizontal space (which "alignment with spaces" assume), I do
>> not think it is unreasonable to accept HT goes to the next
>> column that is multiple of 8 places.
>  
> My argument is ...

Wasn't my 5 lines enough clue to save you from repeating that? I said I do not agree with it, so please don't even try wasting everybody's time on bikeshedding.

Previous: Jakub NarebskiNext: Junio C Hamano
Message 14 of 22 in “Add gitattributes file making whitespace checking pickier”
  1. Add gitattributes file making whitespace checking pickierJ. Bruce Fields, Feb 9, 2008
  2. Daniel BarkalowFeb 9, 2008
  3. J. Bruce FieldsFeb 9, 2008
  4. J. Bruce FieldsFeb 9, 2008
  5. Jakub NarebskiFeb 9, 2008
  6. J. Bruce FieldsFeb 9, 2008
  7. Jakub NarebskiFeb 9, 2008
  8. J. Bruce FieldsFeb 9, 2008
  9. Junio C HamanoFeb 9, 2008
  10. J. Bruce FieldsFeb 9, 2008
  11. Jakub NarebskiFeb 9, 2008
  12. Junio C HamanoFeb 10, 2008
  13. Jakub NarebskiFeb 10, 2008
  14. Junio C HamanoFeb 10, 2008
  15. Add gitattributes file making whitespace checking pickierJunio C Hamano, Feb 10, 2008
  16. J. Bruce FieldsFeb 10, 2008
  17. Daniel BarkalowFeb 10, 2008
  18. Junio C HamanoFeb 10, 2008
  19. Daniel BarkalowFeb 10, 2008
  20. Junio C HamanoFeb 11, 2008
  21. Brian DowningFeb 12, 2008
  22. Junio C HamanoFeb 12, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.