git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add gitattributes file making whitespace checking pickier

From
Jakub Narebski <jnareb@gmail.com>
Date
Feb 9, 2008, 19:36 UTC
Message-ID
<m3abm9hqix.fsf@localhost.localdomain>
In-Reply-To
<20080209190533.GD25533@fieldses.org>
"J. Bruce Fields" <bfields@fieldses.org> writes:
>  gitweb/gitweb.perl                                  |  566 ++--
>  index-pack.c                                        |   30

gitweb (at my insistence) uses tabs for indent, but spaces for align, so that the layout is [roughly] preserved independently of the tab size. IMHO it is superior style, but much harder to check algorithmically (although I send some sketch of idea how to check that at least for aligned commands). That is why there is such a big change.

I'd rather have real bugfixes, real documentation improvements, new features instead of such bikeshedding. If someone is making a change somewhere, he/she can fix the whitespace in the neighbourhood.

-- 
Jakub Narebski
Poland
ShadeHawk on #git
Previous: J. Bruce FieldsNext: J. Bruce Fields
Message 5 of 22 in “Add gitattributes file making whitespace checking pickier”
  1. Add gitattributes file making whitespace checking pickierJ. Bruce Fields, Feb 9, 2008
  2. Daniel BarkalowFeb 9, 2008
  3. J. Bruce FieldsFeb 9, 2008
  4. J. Bruce FieldsFeb 9, 2008
  5. Jakub NarebskiFeb 9, 2008
  6. J. Bruce FieldsFeb 9, 2008
  7. Jakub NarebskiFeb 9, 2008
  8. J. Bruce FieldsFeb 9, 2008
  9. Junio C HamanoFeb 9, 2008
  10. J. Bruce FieldsFeb 9, 2008
  11. Jakub NarebskiFeb 9, 2008
  12. Junio C HamanoFeb 10, 2008
  13. Jakub NarebskiFeb 10, 2008
  14. Junio C HamanoFeb 10, 2008
  15. Add gitattributes file making whitespace checking pickierJunio C Hamano, Feb 10, 2008
  16. J. Bruce FieldsFeb 10, 2008
  17. Daniel BarkalowFeb 10, 2008
  18. Junio C HamanoFeb 10, 2008
  19. Daniel BarkalowFeb 10, 2008
  20. Junio C HamanoFeb 11, 2008
  21. Brian DowningFeb 12, 2008
  22. Junio C HamanoFeb 12, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.