Re: [PATCH/RFC 0/3] Per-repository end-of-line normalization

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: May 7, 2010, 17:10 UTC
Message-ID: <alpine.LFD.2.00.1005071007320.901@i5.linux-foundation.org>
In-Reply-To: <7v4oijhdsi.fsf@alter.siamese.dyndns.org>

On Fri, 7 May 2010, Junio C Hamano wrote:

Show 9 quoted lines

> Eyvind Bernhardsen <eyvind.bernhardsen@gmail.com> writes:
> 
> > - An attribute called "auto-eol" is set in the repository to turn on
> >   normalization of line endings.  Since attributes are content, the
> >   setting is copied when the repository is cloned and can be changed in
> >   an existing repository (with a few caveats).  Setting this attribute
> >   is equivalent to setting "core.autocrlf" to "input" or "true".
> 
> In what way is this attribute different from existing "crlf" attribute?

The existing crlf attribute is a no-op _unless_ core.autocrlf is set, isn't it?

The whole point of Eyvind's series is to be able to set crlf attributes without having to set the config option - because he wants to make sure that a new clone always gets the proper crlf handling without users having to do anything extra.

And I do have to say that it makes sense.

I also do think that maybe we could just change the existing crlf attribute to work even without 'core.autocrlf'.

			Linus