Re: [PATCH/RFC 0/3] Per-repository end-of-line normalization

From: Eyvind Bernhardsen <eyvind@bernhardsen.org>
Date: May 7, 2010, 21:37 UTC
Message-ID: <FA7479D2-1859-4F8B-AC94-013BD6A4F608@bernhardsen.org>
In-Reply-To: <m2z32541b131005071430vcd851ac8yd3c783429a84f875@mail.gmail.com>

On 7. mai 2010, at 23.30, Avery Pennarun <apenwarr@gmail.com> wrote:

Show 19 quoted lines

> On Fri, May 7, 2010 at 5:23 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>> On Fri, 7 May 2010, Eyvind Bernhardsen wrote:
>>> I don't understand.  All you have to do is add "* auto-eol=true"  
>>> to your
>>> .gitattributes, and line endings will be normalized exactly as if  
>>> you'd
>>> set "core.autocrlf".  Why would you have to write totally new rules?
>>> Which rules?
>>
>> I think "* auto-eol=true" is just crazy. We would _never_ want to  
>> do that.
>> Any project that does that should be shot in the head.
>
> In the interests of further making myself look like an idiot:
>
> Just to clarify, is it crazy because that line would convert all
> files, even binary ones, where core.autocrlf auto-detects whether
> files are binary or text?

Just to clarify a bit more, that is _not_ what it would do. The "crlf" attribute is still respected, of course.

Also, I meant to write "* crlf=auto", not "* auto-eol=true", if that makes it any less crazy.

-- 
Eyvind