Re: [PATCH] MSVC: Windows-native implementation for subset of Pthreads API
- From
Nicolas Pitre <nico@fluxnic.net>
- Date
- Nov 4, 2009, 21:52 UTC
- Message-ID
- <alpine.LFD.2.00.0911041634030.10340@xanadu.home>
- In-Reply-To
- <16cee31f0911041316n20fc9f12s6595dadc813d8f46@mail.gmail.com>
On Wed, 4 Nov 2009, Andrzej K. Haczewski wrote:
Show 13 quoted lines
> 2009/11/4 Nicolas Pitre <nico@fluxnic.net>: > > On Wed, 4 Nov 2009, Andrzej K. Haczewski wrote: > > > >> + NO_STATIC_PTHREADS_INIT = YesPlease > > > > Let's not go that route please. If Windows can't get away without > > runtime initializations then let's use them on all platforms. There is > > no gain in exploding the code path combinations here wrt testing > > coverage. > > > > I don't like that approach either, but I was frighten of Junio being > anal about static inits ;).
I think the alternative is much worse than loosing those static inits.
> Let's make it clear: has anyone have any objections that I add > explicit initialization of mutexes and condition variables for POSIX > also?
Please do it and if anyone finds a problem with it then we'll start from there.
Nicolas