Re: [PATCH] MSVC: Windows-native implementation for subset of Pthreads API
- From
Andrzej K. Haczewski <ahaczewski@gmail.com>
- Date
- Nov 5, 2009, 12:53 UTC
- Message-ID
- <16cee31f0911050453w67ef7186l72e22f32a8d8092d@mail.gmail.com>
- In-Reply-To
- <4AF2C4B9.10402@viscovery.net>
2009/11/5 Johannes Sixt <j.sixt@viscovery.net>:
> Elsewhere we use _beginthreadex(). What's the difference?
Oh my, I've just run through MSDN documentation and I'm wrongly using CreateThread. I should have used _beginthread from the start, because besides calling CreateThread it initializes local thread storage for global C-runtime variables (errno etc.), which CreateThread does not do. That could lead to very unpleasant consequences. I'll redo thread creation to use _beginthreadex(). Thanks for that question!
> The pthread_cond_* functions are quite voluminous, but not performance > critical. Could you please move them to pthread.c as well?
Ok, will do.
-- Andrzej