Re: [PATCH] pack-objects: move thread autodetection closer to relevant code
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 6, 2009, 07:20 UTC
- Message-ID
- <7v7hu43yrc.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <alpine.LFD.2.00.0911041623570.10340@xanadu.home>
Nicolas Pitre <nico@fluxnic.net> writes:
> Let's keep thread stuff close together if possible. And in this case, > this even reduces the #ifdef noise, and allows for skipping the > autodetection altogether if delta search is not needed (like with a pure > clone).
Nice. The ll_find_delta() function itself will disappear and becomes the single-threaded find_deltas() when THREADED_DELTA_SEARCH is not defined, and the variable in question is used only inside the function anyway, so this works beautifully.
Very nice.