Re: [PATCH 1/1] MSVC: port pthread code to native Windows threads

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 4, 2009, 11:02 UTC
Message-ID: <alpine.DEB.1.00.0911041201380.2788@felix-maschine>
In-Reply-To: <4AF0E842.2010201@workspacewhiz.com>

Hi,

I do not appreciate at all that you culled me from the Cc: list.

On Tue, 3 Nov 2009, Joshua Jensen wrote:

Show 24 quoted lines

> ----- Original Message -----
> From: Johannes Schindelin
> Date: 11/3/2009 4:38 PM
> > >   #ifdef THREADED_DELTA_SEARCH
> > > -#include "thread-utils.h"
> > > -#include<pthread.h>
> > > +# include "thread-utils.h"
> > > +# ifndef _WIN32
> > > +#  include<pthread.h>
> > > +# else
> > > +#  include<winthread.h>
> > > +# endif
> > >   #endif
> > >
> > >      
> > It is unlikely that an #ifdef "contamination" of this extent will go 
> > through easily, but I have a suggestion that may make your patch both 
> > easier to read and more likely to be accepted into git.git: Try to 
> > wrap the win32 calls into pthread-compatible function signatures.  
> > Then you can add a compat/win32/pthread.h and not even touch core 
> > files of git.git at all.
> >    
> Pardon my ignorance, but is there a reason to not use Pthreads for 
> Win32? http://sourceware.org/pthreads-win32/

Pthreads is a rather large dependency we do not really need.

Ciao, Dscho