Re: [PATCH] MSVC: port pthread code to native Windows threads
2009/11/4 Erik Faye-Lund <kusmabite@googlemail.com>:
Show 16 quoted lines
>
> Seeing how THREAD_RETURN is only called with NULL-parameter, perhaps
> it would be better to do this?
>
> +/*
> + * Properly defines thread routine for Windows and POSIX
> + */
> +#ifndef NO_PTHREADS
> +# ifndef _WIN32
> +# define THREAD_FUNC(f, a) void *f(void *a)
> +# define THREAD_RETURN() return NULL;
> +# else
> +# define THREAD_FUNC(f, a) DWORD __stdcall f(LPVOID a)
> +# define THREAD_RETURN() return 0;
> +# endif
> +#endif
Good point. Should I resubmit the patch again?
Andrew
Andrzej K. Haczewski <ahaczewski@gmail.com>