Re: [PATCH 2/3] git send-email: do not ask questions when --compose is used.
- From
- Ian Hilt <ian.hilt@gmx.com>
- Date
- Nov 1, 2008, 17:54 UTC
- Message-ID
- <alpine.LFD.2.00.0811011323240.23340@sys-0.hiltweb.site>
- In-Reply-To
- <20081101170817.GC26229@artemis.corp>
On Sat, 1 Nov 2008, Pierre Habouzit wrote:
Show 9 quoted lines
> On Sat, Nov 01, 2008 at 01:00:33PM +0000, Ian Hilt wrote: > > I'm confused here. Why would a MIME library help? > > Hmm maybe I'm wrong, but the idea would be to do what mutt does and be > able to parse: > > To: John Doe <some.address@some.tld>, Random Joe <random.joe@abc.def>, > Superman <batman@nyc.us>, > "Someone with a comma, inside its tag name" <a@b.com>
No, you're absolutely right for this reason: MIME-encoded addresses.
Ugh.
Although, to my knowledge, git-send-email doesn't understand that now. So unless we want to support MIME-encoded addresses, this won't be necessary.
> And that needs to know how to do that with perl, and _really_ I hate > perl enough for not being able to do that well. Splitting on ',' is just > not going to fly.
Yea, it's going to be a bit trickier than that.
Show 12 quoted lines
> > > But yeah, I knew I left out those, and this was the reason. > > > > Anyway, do you, or does anyone else, think it's even worth coding the > > possibility for the user to edit the To and Cc fields? > > *YES* > > I would love to see git-send-email work like mutt does: it fills the > field like it does now, and you are allowed to fix that, and it parses > the buffer back to guess what you wanted. It allow to drop most of the > interactive prompting that is so annoying (since it's not in-shell and > has no history and stuff like that, unlike my $EDITOR).
Hmm, I'll look into this; especially the MIME library. I'm not a perl monk, but I can give it a shot, no?
Ian