git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] git send-email: avoid leaking directory file descriptors.

From
Jeff King <peff@peff.net>
Date
Nov 2, 2008, 04:31 UTC
Message-ID
<20081102043120.GD5261@coredump.intra.peff.net>
In-Reply-To
<1225450632-7230-2-git-send-email-madcoder@debian.org>
On Fri, Oct 31, 2008 at 11:57:10AM +0100, Pierre Habouzit wrote:
> +		closedir(DH);

Ugh. This is a great reason to use a scoped variable (like "my $dh), which will close automatically. Once upon a time I think you _had_ to use globs for this, but I think it has not been the case for some time (and I think we only support back to perl 5.6 these days). Can any perl gurus comment?

-Peff
Previous: Pierre HabouzitNext: Pierre Habouzit
Message 16 of 62 in “git send-email improvements”
  1. Pierre HabouzitOct 31, 2008
  2. 1/3 git send-email: avoid leaking directory file descriptors.Pierre Habouzit, Oct 31, 2008
  3. 2/3 git send-email: interpret unknown files as revision listsPierre Habouzit, Oct 31, 2008
  4. 3/3 git send-email: add --annotate optionPierre Habouzit, Oct 31, 2008
  5. Ian HiltOct 31, 2008
  6. Junio C HamanoNov 2, 2008
  7. Pierre HabouzitNov 2, 2008
  8. Matthieu MoyNov 3, 2008
  9. git send-email: allow any rev-list option as an argument.Pierre Habouzit, Oct 31, 2008
  10. Jeff KingNov 2, 2008
  11. Pierre HabouzitNov 2, 2008
  12. Jeff KingNov 2, 2008
  13. Pierre HabouzitNov 3, 2008
  14. Junio C HamanoNov 4, 2008
  15. Pierre HabouzitNov 4, 2008
  16. Jeff KingNov 2, 2008
  17. Further enhancement proposal for git-send-emailPierre Habouzit, Oct 31, 2008
  18. 1/3 git send-email: make the message file name more specific.Pierre Habouzit, Oct 31, 2008
  19. 2/3 git send-email: do not ask questions when --compose is used.Pierre Habouzit, Oct 31, 2008
  20. 3/3 git send-email: turn --compose on when more than one patch.Pierre Habouzit, Oct 31, 2008
  21. Ian HiltOct 31, 2008
  22. Pierre HabouzitOct 31, 2008
  23. Ian HiltOct 31, 2008
  24. Ian HiltNov 1, 2008
  25. Pierre HabouzitNov 1, 2008
  26. Ian HiltNov 1, 2008
  27. Pierre HabouzitNov 1, 2008
  28. Francis GaliegueNov 1, 2008
  29. Pierre HabouzitNov 1, 2008
  30. Francis GaliegueNov 1, 2008
  31. Ian HiltNov 1, 2008
  32. Junio C HamanoNov 2, 2008
  33. Pierre HabouzitNov 2, 2008
  34. Ian HiltNov 2, 2008
  35. Pierre HabouzitNov 3, 2008
  36. [take 2] git send-email updatesPierre Habouzit, Nov 4, 2008
  37. 1/5 git send-email: make the message file name more specific.Pierre Habouzit, Nov 4, 2008
  38. 2/5 git send-email: interpret unknown files as revision listsPierre Habouzit, Nov 4, 2008
  39. 3/5 git send-email: add --annotate optionPierre Habouzit, Nov 4, 2008
  40. 4/5 git send-email: ask less questions when --compose is used.Pierre Habouzit, Nov 4, 2008
  41. 5/5 git send-email: turn --compose on when more than one patch.Pierre Habouzit, Nov 4, 2008
  42. Junio C HamanoNov 4, 2008
  43. Jeff KingNov 5, 2008
  44. Junio C HamanoNov 5, 2008
  45. Pierre HabouzitNov 5, 2008
  46. Junio C HamanoNov 5, 2008
  47. Junio C HamanoNov 9, 2008
  48. Francis GaliegueNov 4, 2008
  49. Junio C HamanoNov 4, 2008
  50. Junio C HamanoNov 4, 2008
  51. [take 2] git send-email updatesPierre Habouzit, Nov 10, 2008
  52. 1/4 git send-email: make the message file name more specific.Pierre Habouzit, Nov 10, 2008
  53. 2/4 git send-email: interpret unknown files as revision listsPierre Habouzit, Nov 10, 2008
  54. 3/4 git send-email: add --annotate optionPierre Habouzit, Nov 10, 2008
  55. 4/4 git send-email: ask less questions when --compose is used.Pierre Habouzit, Nov 10, 2008
  56. Junio C HamanoNov 12, 2008
  57. Junio C HamanoNov 11, 2008
  58. Pierre HabouzitNov 11, 2008
  59. Junio C HamanoNov 12, 2008
  60. Re* [take 2] git send-email updatesJunio C Hamano, Nov 13, 2008
  61. Pierre HabouzitNov 15, 2008
  62. Pierre HabouzitNov 15, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.